chore: add support for proprietary models #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielezhu
changed the title
danielezhu
requested changes
May 13, 2024
src/fmeval/model_runners/util.py
Outdated
| proprietary_models_manifest = f.read().decode("utf-8") | ||
|
|
||
| model = seq(json.loads(proprietary_models_manifest)).find(lambda x: x.get(MODEL_ID, None) == jumpstart_model_id) | ||
| if model: |
There was a problem hiding this comment.
You could remove the is_proprietary variable entirely and simply do
return model is not None
| @@ -146,10 +147,15 @@ def get_jumpstart_sdk_manifest(region: str) -> Dict: | |||
| jumpstart_bucket_base_url = os.environ.get( | |||
There was a problem hiding this comment.
Please update the return type to List[Dict].
There was a problem hiding this comment.
We are trying to fetch a value as a dict later in the flow. Does this become a list or will it remain a dict?
There was a problem hiding this comment.
This static method actually returns a list of dict, hence need to change that to List[Dict]. Later in the flow where we are using this method, we get an item as a dict from the returned list and use that dict to get modelId for checking valid model id.
danielezhu
approved these changes
May 14, 2024
danielezhu
approved these changes
May 14, 2024
keerthanvasist
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Need to add changes to support proprietary models.
Description of changes:
jumpstart_extractor.pyto support proprietary model manifest file for validationjumpstart_composer.pyto supportmodel_typeas proprietary forcomposemethod.sm_jumpstart_model_runner.pyto supportmodel_typeas proprietary for creating apredictor.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.