feat: add BERT_SCORE to QAAccuracySemanticRobustness
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirupang-code
changed the title
BERT_SCORE to QAAccuracySemanticRobustness + updated testsBERT_SCORE to QAAccuracySemanticRobustness + updated tests
danielezhu
requested changes
Aug 15, 2024
| @@ -105,11 +107,13 @@ class TestCaseQAAccuracySemanticRobustnessEvaluateSample(NamedTuple): | |||
| EvalScore(name=QUASI_EXACT_MATCH_SCORE, value=1.0), | |||
| EvalScore(name=PRECISION_OVER_WORDS, value=1.0), | |||
| EvalScore(name=RECALL_OVER_WORDS, value=1.0), | |||
| EvalScore(name=BERT_SCORE, value=0.48504769802093506), | |||
There was a problem hiding this comment.
We should be mocking the bertscore model in the unit tests. We need the unit tests to validate that all of the new logic that was added to the transform pipeline is correct. Currently, none of this logic is getting tested.
There was a problem hiding this comment.
Ok, will work on that
oyangz
approved these changes
Aug 15, 2024
danielezhu
changed the title
BERT_SCORE to QAAccuracySemanticRobustness + updated testsBERT_SCORE to QAAccuracySemanticRobustness
danielezhu
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitWithDelimitertransform to addBERT_SCOREandDELTA_BERT_SCOREtoQAAccuracySemanticRobustness. Created a shared resource of the bertscore model to be used in the evaluate function inqa_accuracy_semantic_robustnessto reduce the amount of memory consumed.triviaQA_sample_small.jsonl, to be used in integration tests because existing integration tests timed out with the 100 records intriviaQA_sample_small.jsonl.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.