test: implement factual knowledge integration test #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keerthanvasist
previously approved these changes
Oct 18, 2023
| remove_prompt_from_generated_text: bool = True | ||
|
|
||
|
|
||
| class HuggingFaceCausalLLMModelRunner(ModelRunner): |
There was a problem hiding this comment.
Should we move this to model_runners folder in src?
There was a problem hiding this comment.
Currently, the HF model runner doesn't conform to the ModelRunner interface, as it was presumably just meant for demo purposes. I think that I will have to update the ModelRunner interface in a separate PR before we can treat HuggingFaceCausalLLMModelRunner as a "real" ModelRunner.
Currently, ModelRunner has endpoint-invocation ideas baked into the interface (for example, content_type and accept_type). I think it will be a good idea to update it to be more general.
danielezhu
force-pushed
the
integ_tests
branch
from
4438260
to
f7e6074
Compare
malhotra18
approved these changes
Oct 18, 2023
keerthanvasist
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR implements an integration test for the factual knowledge evaluation algorithm, using a custom model runner that uses GPT2 model supplied by Huggingface.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.