Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update devtool all command so that it works when run from a freshly-cloned repo #44

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

danielezhu
Copy link
Contributor

@danielezhu danielezhu commented Oct 18, 2023

Issue #, if available:

Description of changes:
Currently, our Github actions job is doing the following:

./devtool env_setup
./devtool install_deps
./devtool unit_test_with_coverage
./devtool build_package

./devtool all currently does almost the same thing, except instead of step 2, it does install_poetry instead of install_deps.

As a result, if you run devtool all right after cloning this repo, the unit_test_with_coverage command will fail because import statements in unit tests will fail. The key command that needs to be run is poetry install, which gets called by install_deps. This will install not only the project dependencies, but the project itself, which is critical for import statements to work.

Note that subsequent calls to devtool all will not take a long time re-installing all of the dependencies; if there is no change to the dependencies, install_deps is basically a no-op.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@danielezhu danielezhu merged commit b770144 into main Oct 18, 2023
4 checks passed
@danielezhu danielezhu deleted the devtool_update branch October 18, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants