fix: update devtool all command so that it works when run from a freshly-cloned repo #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently, our Github actions job is doing the following:
./devtool all
currently does almost the same thing, except instead of step 2, it doesinstall_poetry
instead ofinstall_deps
.As a result, if you run
devtool all
right after cloning this repo, theunit_test_with_coverage
command will fail because import statements in unit tests will fail. The key command that needs to be run ispoetry install
, which gets called byinstall_deps
. This will install not only the project dependencies, but the project itself, which is critical for import statements to work.Note that subsequent calls to
devtool all
will not take a long time re-installing all of the dependencies; if there is no change to the dependencies,install_deps
is basically a no-op.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.