fix: increase ABS_TOL to account for non-deterministic models #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satish615
previously approved these changes
Nov 1, 2023
nathanng17
previously approved these changes
Nov 1, 2023
pinaraws
previously approved these changes
Nov 1, 2023
danielezhu
dismissed stale reviews from pinaraws, nathanng17, and Satish615
via
95bde37
oyangz
approved these changes
Nov 1, 2023
nathanng17
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
ABS_TOLis used when comparing twoEvalScoreobjects via the__eq__method. The main use case for comparingEvalScoreobjects is in testing. End-to-end container tests rely onEvalScorecomparison when comparingoutput.jsonresults.Because some models cannot be made deterministic, the same processing job will produce
output.jsonwhere theEvalScores may be off by ~1e-3. These outputs should be treated as equal, for the purpose of testing. Thus, we need to increase the tolerance used by__eq__accordingly.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.