Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make BertscoreHelperModel a ray actor #95

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

danielezhu
Copy link
Contributor

@danielezhu danielezhu commented Nov 4, 2023

Issue #, if available:

Description of changes:
Please see this quip doc that provides a detailed explanation for the problem that this PR fixes.

I have tested these changes using the Summarization Accuracy integration tests from this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@pinaraws pinaraws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@danielezhu danielezhu merged commit e3f9b7b into aws:main Nov 6, 2023
3 checks passed
@danielezhu danielezhu deleted the bert_model_fix branch November 6, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants