Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Connector Part 2 - raw ID type map #367

Merged
merged 2 commits into from
May 10, 2024

Conversation

kmcginnes
Copy link
Collaborator

Description

This raw ID type map was being stored next to the connector state. It is a lookup for a vertex ID to its original type before it was mapped to a string.

Instead, I store this value on the VertexData instance. It should use the same or less memory and avoids all the strange state logic needed to maintain the map.

Validation

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk May 10, 2024 21:36
@kmcginnes kmcginnes changed the title Refactor Connector Part 1 - raw ID type map Refactor Connector Part 2 - raw ID type map May 10, 2024
@kmcginnes kmcginnes merged commit 645a050 into aws:main May 10, 2024
1 check passed
@kmcginnes kmcginnes deleted the raw-id-type-map branch May 10, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants