Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move node count by type query #441

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Move node count by type query #441

merged 2 commits into from
Jun 18, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 17, 2024 •
edited
Loading

Description

  • Moves the node count by type query in to the shared queries file
  • Adds container component to ensure vertexType is assigned (which it always will be)

Validation

  • Tested by trying Data Explorer on a few different connections
  • Observed React Query dev tools

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 17, 2024 22:22
@kmcginnes kmcginnes merged commit ae6e7d9 into aws:main Jun 18, 2024
1 check passed
@kmcginnes kmcginnes deleted the move-queries branch June 18, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkagamlyk vkagamlyk vkagamlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Wrap fetchVertexCountsByType in React Query
2 participants
@kmcginnes @vkagamlyk