Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openCypher neighbor expansion and counts #449

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 21, 2024

Description

Fixes openCypher issues around neighbor expansion and neighbor counts.

  • Fixes issue where neighbor query returned edges with the wrong type for source and target types
  • Fixes neighbor count to respect limits
  • Fixes limit and offset in neighbor query
  • Fixes edges in neighbor query to return all edges between source and target nodes
  • Fixes limit and offset calculations in expand side bar to use typed counts rather than total counts
  • Better formatting of queries in logic and tests

Validation

  • Tested many expansion options
  • Tested multiple expansions with limit (paging results)
  • Tested with bidirectional edges

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes requested a review from vkagamlyk June 21, 2024 16:07
@kmcginnes kmcginnes marked this pull request as ready for review June 21, 2024 16:07
Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kmcginnes kmcginnes merged commit d2e8b60 into aws:main Jun 21, 2024
1 check passed
@kmcginnes kmcginnes deleted the fix-limit-cypher branch June 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants