Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser-specific issues with fullscreen graph widget #427

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Jan 13, 2023

Issue #, if available: #421

Description of changes:

  • Modified graph widget to use prefixed Fullscreen API attributes to fix browser-specific issues. Derived from the solution provided by @jklap in the referenced issue. These changes have been verified on Safari 16.2, Firefox 102.5.0esr, Chrome 109.x, and Edge 109.x.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaelnchin michaelnchin linked an issue Jan 13, 2023 that may be closed by this pull request
@michaelnchin michaelnchin merged commit 623f7cc into main Jan 14, 2023
@michaelnchin michaelnchin deleted the Issue-421 branch January 14, 2023 00:09
sojiadeshina pushed a commit to sojiadeshina/graph-notebook that referenced this pull request Jan 16, 2023
* Fix browser-specific issues with fullscreen graph widget

* update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>
bechbd pushed a commit that referenced this pull request Mar 1, 2023
* Fix browser-specific issues with fullscreen graph widget

* update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>
michaelnchin added a commit that referenced this pull request Mar 8, 2023
* Added notebooks for learning openCypher

* Updated Answer Key with the correct Notebook names

* Updated per feedback from Joy for PR420

* Bump setuptools from 40.6.2 to at >=65.5.1 (#424)

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Add ECR publish workflow (#405)

* Add ECR publish action

* disable version check

* Use package version as image tag

* Remove test code

* Fix for ECR public

* Remove version tagging for pre-release images

* Use new registry alias

* update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Truncate metadata request/query time metrics (#425)

* Truncate metadata request/query time metrics

* update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Fix browser-specific issues with fullscreen graph widget (#427)

* Fix browser-specific issues with fullscreen graph widget

* update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Pin itables<1.4.3 (#429)

* Pin itables<1.4.3

* update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Fix upper bound on all dependencies (#431)

* Fix upper bound on all dependencies

* Remove manual prerequisite installations

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Release 3.7.1 (#432)

* Bump to 3.7.1

* Update release date

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Fix property key in gremlin statement (#434)

Fix property key in gremlin statement as per TinkerPop’s "Modern" graph

* Bump itables to 1.4.5 (#436)

* Bump itables to 1.4.5

* Update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Update v3.7.1 release date

* Run unit tests on external pull requests (#437)

* Run unit tests on external pull requests

* Prevent duplicate runs for internal branch PRs

* Update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Use updated authentication method for IAM Bolt queries (#438)

* Use updated authentication method for IAM Bolt queries

* update changelog

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Update unit.yml

* Do not sign non-IAM Bolt requests

Per: https://docs.aws.amazon.com/neptune/latest/userguide/access-graph-opencypher-bolt.html#access-graph-opencypher-bolt-python

* adding fraud detection with inductive inference notebook (#417)

* adding fraud detection with inductive inference notebook

* updating notebook with review comments

* update number of nodes to reflect correct dataset size

* make sure node id used for transductive query is consistent

* additional nb comments and fixes

* remove references to nondeterministic and transductive as those are dummy keywords

* updating with inline edits and adding note before package install

* update description of why neptune_ml_utils is needed

* minor edit to examples for consistent behavior with documentation (#440)

* Unit test and changelog modification for #417 (#441)

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Add changelog entry for #419

* Correct a typo in 03-Real-Time-Fraud-Detection-Using-Inductive-Inference ML notebook(#444)

* Add --profile-misc-args option to %%gremlin (#443)

* Add --profile-misc-args option to %%gremlin

* update changelog

---------

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Fix Webpack failure in CI builds (#447)

Co-authored-by: Michael Chin <chnmch@amazon.com>

* Pin node version in unit.yml (#449)

Co-authored-by: Michael Chin <chnmch@amazon.com>

---------

Co-authored-by: Dave Bechberger <dbechbe@amazon.com>
Co-authored-by: Michael Chin <mchin188@yahoo.com>
Co-authored-by: Michael Chin <chnmch@amazon.com>
Co-authored-by: Puneet Goyal <puneet97.goyal@gmail.com>
Co-authored-by: Soji Adeshina <adesojia@amazon.com>
Co-authored-by: Hua Shu <hshu2000@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Full screen Visualization does not work in Safari
1 participant