Converted "amount" datatype from String to numeric for "Transaction" vertices #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pin JupyterLab<4.x * Update changelog --------- Co-authored-by: Michael Chin <chnmch@amazon.com>
|
Thanks Stephen. Would like to get a very quick review from @iansrobinson who I believe created the dataset to make sure there was no specific reason why strings were used. |
iansrobinson
previously approved these changes
May 18, 2023
michaelnchin
approved these changes
May 18, 2023
michaelnchin
pushed a commit
that referenced
this pull request
May 30, 2023
…vertices (#489) * Converted "amount" datatype from String to numeric for "Transaction" vertices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't think of a reason for "amount" to be non-numeric. Would be nice to be able to do
sum()and or different equality functions on that property value as a number.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.