Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for %load_status details, errors, and pagination. #88

Merged
merged 4 commits into from
Mar 22, 2021

Conversation

triggan
Copy link
Contributor

@triggan triggan commented Mar 19, 2021

Issue #, if available: Issues 14 and 24

Description of changes: Adding parameter flags to %load_status magic in order to include details and errors for bulk loader status queries. Also including the necessary parameters for pagination (page and errorsPerPage) per the Neptune documentation here: https://docs.aws.amazon.com/neptune/latest/userguide/load-api-reference-status-requests.html

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@austinkline austinkline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm a little torn about whether to make the new parameters optional or not by assigning them defaults. But since we are handling default use cases in the arg parser we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%load_status should accept parameters Add ability to return details/errors from %load_status
2 participants