Skip to content

Commit de3f062

Browse files
authored
feat(jsii): Further normalize assembly outputs (#177)
Sort member arrays (`properties` and `methods`), to produce fully sorted assemblies: 1. `static` members 2. `immutable` members (only relevant for `properties`) 3. non-`optional` members (only relevant for `properties`) 4. lexicographically sorted Also, stop emitting step builders for interfaces in Java (they break due to the property order change the above causes). Conveniently, this fixes #60.
1 parent 46f1771 commit de3f062

File tree

108 files changed

+2691
-2517
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

108 files changed

+2691
-2517
lines changed

packages/jsii-calc-base-of-base/test/assembly.jsii

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
2-
"fingerprint": "I/HF4zJK5eV4ZLmNLDEzShkHVsxngX3K/y2SEYjXsxU=",
32
"author": {
43
"name": "Amazon Web Services",
54
"organization": true,
@@ -68,5 +67,6 @@
6867
]
6968
}
7069
},
71-
"version": "0.6.4"
70+
"version": "0.6.4",
71+
"fingerprint": "I/HF4zJK5eV4ZLmNLDEzShkHVsxngX3K/y2SEYjXsxU="
7272
}

packages/jsii-calc-base/test/assembly.jsii

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
2-
"fingerprint": "b+UZfT/No0vxqTQ1n3lIsyw7olqARDbeGj853lNFoE8=",
32
"author": {
43
"name": "Amazon Web Services",
54
"organization": true,
@@ -100,5 +99,6 @@
10099
]
101100
}
102101
},
103-
"version": "0.6.4"
102+
"version": "0.6.4",
103+
"fingerprint": "b+UZfT/No0vxqTQ1n3lIsyw7olqARDbeGj853lNFoE8="
104104
}

packages/jsii-calc-lib/test/assembly.jsii

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
2-
"fingerprint": "qwjIHOtTOSWOv5qzVdHj4SDgxmnWYsacVvR7BkAVlo8=",
32
"author": {
43
"name": "Amazon Web Services",
54
"organization": true,
@@ -125,20 +124,20 @@
125124
"properties": [
126125
{
127126
"docs": {
128-
"comment": "A string value"
127+
"comment": "An awesome number value"
129128
},
130-
"name": "astring",
129+
"name": "anumber",
131130
"type": {
132-
"primitive": "string"
131+
"primitive": "number"
133132
}
134133
},
135134
{
136135
"docs": {
137-
"comment": "An awesome number value"
136+
"comment": "A string value"
138137
},
139-
"name": "anumber",
138+
"name": "astring",
140139
"type": {
141-
"primitive": "number"
140+
"primitive": "string"
142141
}
143142
},
144143
{
@@ -187,20 +186,20 @@
187186
"properties": [
188187
{
189188
"docs": {
190-
"comment": "The number."
189+
"comment": "The number multiplied by 2."
191190
},
192191
"immutable": true,
193-
"name": "value",
192+
"name": "doubleValue",
194193
"type": {
195194
"primitive": "number"
196195
}
197196
},
198197
{
199198
"docs": {
200-
"comment": "The number multiplied by 2."
199+
"comment": "The number."
201200
},
202201
"immutable": true,
203-
"name": "doubleValue",
202+
"name": "value",
204203
"type": {
205204
"primitive": "number"
206205
}
@@ -315,5 +314,6 @@
315314
]
316315
}
317316
},
318-
"version": "0.6.4"
317+
"version": "0.6.4",
318+
"fingerprint": "MHdlbqyf1RV6moIHslfpKnl7yjQoYVvvZLfxFXWihrU="
319319
}

0 commit comments

Comments
 (0)