Python: cannot extend generated classes in an idiomatic way

[gshpychka]

Describe the bug

Take the class NatProvider:
https://github.com/aws/aws-cdk/blob/d03543246c5659cb287566372d47564e6fc2df4c/packages/%40aws-cdk/aws-ec2/lib/nat.ts#L55

I'm implementing my own provider in Python, so I extend the class.
When I implement the configure_nat method, I cannot use the same method signature as in the generated classes.

In the generated code, the signature for that method is the following:

def configure_nat(self, *, nat_subnets: typing.Sequence["PublicSubnet"], private_subnets: typing.Sequence["PrivateSubnet"], vpc: "Vpc")

When I replicate that in my child class, I cannot use this signature.

Expected Behavior

I should be able to extend the class and use the method signatures that match the ones in the generated python code for the parent class.

Current Behavior

When I replicate the method with the same signature, I get this at synth:

jsii.errors.JSIIError: MyNatProvider.configure_nat() takes 1 positional argument but 2 were given

To actually implement the class, my method signature has to be:

def configure_nat(self, options: ec2.ConfigureNatOptions, /)

Reproduction Steps

Subclass NatProvider and implement configure_nat with a method signature that matches the generated parent class.

Possible Solution

No response

Additional Information/Context

No response

SDK version used

1.61.0

Environment details (OS name and version, etc.)

Linux

[RomainMuller]

Hey!

Can you provide a minimal repro for this issue? That'll help me diagnose & fix it faster...

Thanks!

[gshpychka]

@jsii.implements(ec2.IConnectable)
class MyNatProvider(ec2.NatProvider):
    def __init__(
        self,
    ) -> None:
        super().__init__()

    # this synths fine, but produces a typing error (Method "configure_nat" overrides class "NarProvider" in an incompatible manner)
    '''def configure_nat(  # type: ignore[misc]
        self, options: ec2.ConfigureNatOptions, /
    ) -> None:
        pass'''


    # this is the idiomatic way to override the method, but does not synth
     def configure_nat(
        self,
        *,
        nat_subnets: typing.Sequence[ec2.Subnet],
        private_subnets: typing.Sequence[ec2.PrivateSubnet],
        vpc: ec2.Vpc
    ) -> None:
        pass

vpc = ec2.Vpc(
    self,
    "Vpc",
    nat_gateways=1,
    nat_gateway_provider=MyNatProvider(),
)

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.