feat(.net): dynmic type checking for union-typed parameters #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weaving runtime type checks around union-typed parameters to help developers receive actionable error messages in case mistakes are made. The checks are only woven if the `DEBUG` preprocessor constant is set, which means these checks will not be done on `Release` builds, which optimize for speed. Fixes #3640
RomainMuller
force-pushed
the
rmuller/type-check-dotnet-unions
branch
from
a7b6d14
to
29be798
Compare
RomainMuller
force-pushed
the
rmuller/type-check-dotnet-unions
branch
from
4c81c76
to
ae33199
Compare
comcalvi
reviewed
Aug 3, 2022
Co-authored-by: Calvin Combs <66279577+comcalvi@users.noreply.github.com>
…tnet-unions # Conflicts: # packages/jsii-calc/test/assembly.jsii
…tnet-unions # Conflicts: # packages/jsii-calc/test/assembly.jsii # packages/jsii-pacmak/lib/targets/dotnet/dotnetgenerator.ts
comcalvi
approved these changes
Aug 9, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaving runtime type checks around union-typed parameters to help
developers receive actionable error messages in case mistakes are made.
The checks are only performed if the
Amazon.JSII.Runtime.Configuration.RuntimeTypeCheckingconfigurationproperty is
true(which it is by default).A pre-processor macro such as
DEBUGcould not be used as the packagespublished to NuGet are already built and this does not afford any control
to the end-user.
Fixes #3640
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.