fix(dotnet): AnonymousObject fails runtime type checks #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AnonymousObject` class is used when a value is passed from JS to .NET through a union or `any` typed return point, and there is not sufficient runtime type information on the value to decisively identify its dynamic type. The `AnonymousObject` class will be converted by the jsii runtime to any interface type implicitly (even if that is technically not correct), and it must hence be allowed through runtime type-checks for interfaces. Essentially, this is a blind spot of the runtime type checks, and should not cause valid code to break.
RomainMuller
added
bug
RomainMuller
commented
Aug 17, 2022
Comment on lines
+723
to
+726
| const varName = `__idx_${createHash('sha256') | ||
| .update(descr) | ||
| .digest('hex') | ||
| .slice(0, 6)}`; |
There was a problem hiding this comment.
Unrelated, but makes the generated code more readable, which makes it less likely that a bad change is missed by human scrutiny.
RomainMuller
commented
Aug 17, 2022
Comment on lines
+747
to
+750
| const varName = `__item_${createHash('sha256') | ||
| .update(descr) | ||
| .digest('hex') | ||
| .slice(0, 6)}`; |
There was a problem hiding this comment.
Unrelated, but makes the generated code more readable, which makes it less likely that a bad change is missed by human scrutiny.
RomainMuller
changed the title
comcalvi
approved these changes
Aug 17, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
|
Merging (with squash)... |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AnonymousObjectclass is used when a value is passed from JS to.NET through a union or
anytyped return point, and there is notsufficient runtime type information on the value to decisively identify
its dynamic type. The
AnonymousObjectclass will be converted by thejsii runtime to any interface type implicitly (even if that is
technically not correct), and it must hence be allowed through runtime
type-checks for interfaces. Essentially, this is a blind spot of the
runtime type checks, and should not cause valid code to break.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.