Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pacmak): allow opt-out of runtime type checking generation #3710

Merged
merged 5 commits into from
Aug 18, 2022

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Aug 17, 2022

Adds a new CLI flag --no-runtime-type-checking to allow library authors to
opt out of generating runtime type checking code if they are not interested
in those.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds a new CLI flag --no-runtime-type-checking to allow library authors to
opt out of generating runtime type checking code if they are not interested
in those.
@RomainMuller RomainMuller requested a review from a team August 17, 2022 10:11
@RomainMuller RomainMuller self-assigned this Aug 17, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

Merging (with squash)...

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2022

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

Merging (with squash)...

@mergify mergify bot merged commit 39923a5 into main Aug 18, 2022
@mergify mergify bot deleted the rmuller/runtime-type-check-opt-out branch August 18, 2022 10:13
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants