fix(jsii): unable to depend on modules with private declarations #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a TypeScript [bug], it was impossible to write a jsii module that takes a dependency on a module that has private type declarations in their d.ts file since they are untyped by definition. This temporary fix sets `noImplicitAny` to `false` in order to disable this check and enable the dependency use case until we upgrade to the 3.7.x version-line. Fixes #994 [bug]: microsoft/TypeScript#33894
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
approved these changes
Nov 17, 2019
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a TypeScript bug, it was impossible to write a jsii module that takes a dependency on a module that has private type declarations in their d.ts file since they are untyped by definition.
This temporary fix sets
noImplicitAnytofalsein order to disable this check and enable the dependency use case until we upgrade to the 3.7.x version-line.Fixes #994
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.