Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii): unable to depend on modules with private declarations #995

Merged
merged 1 commit into from
Nov 17, 2019
Merged

fix(jsii): unable to depend on modules with private declarations #995

merged 1 commit into from
Nov 17, 2019

Commits on Nov 17, 2019

  1. fix(jsii): unable to depend on modules with private declarations 

    Due to a TypeScript [bug], it was impossible to write a jsii module
that takes a dependency on a module that has private type declarations
in their d.ts file since they are untyped by definition.

This temporary fix sets `noImplicitAny` to `false` in order to disable
this check and enable the dependency use case until we upgrade to the 3.7.x
version-line.

Fixes #994

[bug]: microsoft/TypeScript#33894
    Elad Ben-Israel committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    2e9852c View commit details
    Browse the repository at this point in the history