Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noImplicitAny is temporarily disabled #996

Closed
eladb opened this issue Nov 17, 2019 · 0 comments · Fixed by #988
Closed

noImplicitAny is temporarily disabled #996

eladb opened this issue Nov 17, 2019 · 0 comments · Fixed by #988
Assignees
@RomainMuller
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1

Comments

@eladb
Copy link
Contributor

eladb commented Nov 17, 2019 •
edited
Loading

To unblock #995 without requiring to upgrade TypeScript, the option noImplicitAny has been disabled from the tsconfig.json generated by the jsii compiler.

Once we upgrade to the 3.7.x version-line, we should be able to restore this validation, although might be tricky since it's a breaking change... Might need to wait until the next major version bump.
@eladb eladb added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 17, 2019
@RomainMuller RomainMuller mentioned this issue Nov 26, 2019
Merged
@mergify mergify bot closed this as completed in #988 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: upgrade to typescript 3.7 aws/jsii
2 participants
@RomainMuller @eladb