Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to typescript 3.7 #988

Merged
merged 9 commits into from
Nov 26, 2019
Merged

feat: upgrade to typescript 3.7 #988

merged 9 commits into from
Nov 26, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Nov 14, 2019 •
edited
Loading

Enjoy the benefits of optional chaining, a null-coalescing operator, and other
fun new features and enhancements TypeScript brought in 3.7. For more
information about the TypeScript features, refer to the TypeScript release notes.

Closes #996

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RomainMuller
feat: upgrade to typescript 3.7
483e66f 
Enjoy the benefits of optional chaining, a null-coalescing operator, and other
fun new features and enhancements TypeScript brought in 3.7.  For more
information about the TypeScript features, refer to the [TypeScript release notes].

[TypeScript release notes]: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html
@RomainMuller RomainMuller added the pr/do-not-merge This PR should not be merged at this time. label Nov 14, 2019
@RomainMuller RomainMuller requested a review from a team as a code owner November 14, 2019 13:29
@RomainMuller RomainMuller self-assigned this Nov 14, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 15, 2019

Even more importantly for ergonomics, command-clicking on an identifier will send you to the .ts file instead of the .d.ts file!

@RomainMuller RomainMuller removed the pr/do-not-merge This PR should not be merged at this time. label Nov 26, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb approved these changes Nov 26, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/jsii-diff/lib/type-analysis.ts Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2019

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot merged commit 6e0a7e6 into master Nov 26, 2019
@mergify mergify bot deleted the rmuller/typescript-3.7 branch November 26, 2019 11:27
@mergify mergify bot removed the ready-to-merge label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@RomainMuller RomainMuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

noImplicitAny is temporarily disabled
4 participants
@RomainMuller @aws-cdk-automation @rix0rrr @eladb