feat(jsii): exclude files in tsconfig.json

[nija-at]

Commit Message

This change lets package.json of a jsii package to specify additional
'exclude' paths. They are encoded into tsconfig.json.

Motivation
jsconfig is a common way to configure tools like eslint and jest. These
files have the 'js' extension but should not be compiled into the
package. This flag lets the jsii compiled packages to configure this.

End Commit Message

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[eladb]

Not sure what’s I am seeing here? Seems like we already have this feature under a different name, no?

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
• Commit ID: ffad449
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[nija-at]

Are you referring to the property excludeTypescript? It wasn't clear why there's the typescript suffix, so I've tried to unify it under one property called exclude.

[eladb]

Are you referring to the property excludeTypescript? It wasn't clear why there's the typescript suffix, so I've tried to unify it under one property called exclude.

I’ll let @RomainMuller chime in on this.

[RomainMuller]

Are you referring to the property excludeTypescript? It wasn't clear why there's the typescript suffix, so I've tried to unify it under one property called exclude.

I’ll let @RomainMuller chime in on this.

Well that was introduced in #343, and since the PR was mostly about something else it flew in.

But I'm generally favorable of modeling all the TypeScript compilation tweaks as an object under the jsii.tsc key, where the key for each option is the same as what's in tsconfig.json.

I am also wondering if we took a wrong turn in generating the tsconfig.json systematically, and whether we should actually allow a hand-written file with the other jsii configuration in there -- but this is a conversation for later.

[RomainMuller]

Breaks surrounding style, and you might not want to fix them all up, so take it or leave it:

Suggested change

	exclude: (pkg.jsii && pkg.jsii.exclude) || [],
	exclude: pkg.jsii?.exclude ?? [],