Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check against downgrading proeprties to readonly #201

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

RomainMuller
Copy link
Contributor

Fixes #199 that was discovered by @moofish32

@RomainMuller RomainMuller merged commit f60b0ac into master Aug 26, 2018
@RomainMuller RomainMuller deleted the rmuller/fix-downgrade-to-readonly branch August 26, 2018 12:07
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

eladb pushed a commit that referenced this pull request Aug 28, 2018
### Bug Fixes

* **jsii-pacmak:** Output .NET build artifacts to `dist/dotnet/` instead of just `dist/` ([#192](#192)) ([f25c8c4](f25c8c4))
* **jsii-kernel:** Fix module loading on systems that use '\' instead of '/' as the path separator ([#193](#193)) ([9e42991](9e42991))

### Features

* **jsii:** Add check against downgrading properties to readonly ([#201](#201)) ([f60b0ac](f60b0ac))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants