Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node runtime version check #2948

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

RomainMuller
Copy link
Contributor

Checks the current version of node against a list of SemVer rangers
that are configured in @jsii/node-check, and emit a BIG FAT warning
to STDERR (with color if possible) in case the version is found to be
end-of-life, deprecated, or untested, so that users know that they are
subjecting themselves to random problems.

When marking a range as deprecated, a deadline is also provided in the
message, informing users about when the releases will move to the
end-of-life support level.


The check is performed at the entry point of all CLI utilities, including the
@jsii/runtime entry point.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Checks the current version of `node` against a list of SemVer rangers
that are configured in `@jsii/node-check`, and emit a BIG FAT warning
to STDERR (with color if possible) in case the version is found to be
end-of-life, deprecated, or untested, so that users know that they are
subjecting themselves to random problems.

When marking a range as deprecated, a deadline is also provided in the
message, informing users about when the releases will move to the
end-of-life support level.
@RomainMuller RomainMuller self-assigned this Aug 10, 2021
@RomainMuller RomainMuller requested a review from a team August 10, 2021 14:31
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2021

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@Chriscbr Chriscbr added the pr/do-not-merge This PR should not be merged at this time. label Aug 11, 2021
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving pr/do-not-merge in case @MrArnoldPalmer wants to take another look.

# `@jsii/check-node`

This package can be used to check whether the node runtime used to run an
application is known to be compatible with the `jsii` constellation of packages,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the visual I have of jsii packages as a constellation! ✨

@RomainMuller RomainMuller removed the pr/do-not-merge This PR should not be merged at this time. label Aug 12, 2021
@RomainMuller
Copy link
Contributor Author

Leaving pr/do-not-merge in case @MrArnoldPalmer wants to take another look.

Well I do need this to ship sooner rather than later, so I removed the label... That doesn't mean @MrArnoldPalmer doesn't get to have another look (but feedback will be addressed in a follow-up)

@RomainMuller RomainMuller removed the request for review from MrArnoldPalmer August 12, 2021 15:58
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 12, 2021
@mergify mergify bot merged commit f0a9ec6 into main Aug 12, 2021
@mergify mergify bot deleted the rmuller/soft-deprecate-node10 branch August 12, 2021 15:59
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants