-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: node runtime version check #2948
Conversation
Checks the current version of `node` against a list of SemVer rangers that are configured in `@jsii/node-check`, and emit a BIG FAT warning to STDERR (with color if possible) in case the version is found to be end-of-life, deprecated, or untested, so that users know that they are subjecting themselves to random problems. When marking a range as deprecated, a deadline is also provided in the message, informing users about when the releases will move to the end-of-life support level.
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving pr/do-not-merge in case @MrArnoldPalmer wants to take another look.
# `@jsii/check-node` | ||
|
||
This package can be used to check whether the node runtime used to run an | ||
application is known to be compatible with the `jsii` constellation of packages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the visual I have of jsii packages as a constellation! ✨
Well I do need this to ship sooner rather than later, so I removed the label... That doesn't mean @MrArnoldPalmer doesn't get to have another look (but feedback will be addressed in a follow-up) |
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Checks the current version of
node
against a list of SemVer rangersthat are configured in
@jsii/node-check
, and emit a BIG FAT warningto STDERR (with color if possible) in case the version is found to be
end-of-life, deprecated, or untested, so that users know that they are
subjecting themselves to random problems.
When marking a range as deprecated, a deadline is also provided in the
message, informing users about when the releases will move to the
end-of-life support level.
The check is performed at the entry point of all CLI utilities, including the
@jsii/runtime
entry point.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.