fix(python): unable to implement additional interfaces #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a type extends a jsii class, any additional interfaces implemented via the `@jsii.implements` annotation were not properly registered, and overrides were not properly discovered. This was the combination of a code-generation bug, which caused the type passed to the `create` kernel method to be that of the jsii class, instead of the dynamic class (`self.__class__`); and a kernel bug, which caused those inheritance graphs to completely skip overrides detection. Fixes #2963
rix0rrr
approved these changes
Aug 19, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type extends a jsii class, any additional interfaces implemented
via the
@jsii.implementsannotation were not properly registered, andoverrides were not properly discovered.
This was the combination of a code-generation bug, which caused the type
passed to the
createkernel method to be that of the jsii class,instead of the dynamic class (
self.__class__); and a kernel bug, whichcaused those inheritance graphs to completely skip overrides detection.
Fixes #2963
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.