chore: remove jest-expect-message
#3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combination of: * jest 27 * ts-jest * jest-expect-message Leads to any test that wants to report an error message failing with the error: ``` TypeError: matcherResult.message is not a function ``` (ref: mattphillips/jest-expect-message#39) The result is that the actual error is swallowed, and this is very unhelpful. Since we only used to use `jest-expect-message` in one place anyway, remove it.
nija-at
approved these changes
Oct 7, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combination of:
Leads to any test that wants to report an error message failing with
the error:
(ref: mattphillips/jest-expect-message#39)
The result is that the actual error is swallowed, and this is very
unhelpful.
Since we only used to use
jest-expect-messagein one place anyway,remove it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.