feat(go-runtime): include error message when wrapping a @jsii/kernel.Fault #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
bmoffatt
changed the title
mrgrain
previously approved these changes
Dec 15, 2023
mrgrain
changed the title
mrgrain
changed the title
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
mergify
bot
dismissed
mrgrain’s stale review
Pull request has been modified.
mrgrain
approved these changes
Dec 15, 2023
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this error message when developing a JSII compatible construct.
Including the de-serialized error message into the wrapped error helped me debug that I was missing the
.jsiifile in my distribution! (eg: I needed to add".jsii"to the"files"list in my construct'spackage.json)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.