Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsii-spec): Model parameter optionality #432

Merged
merged 8 commits into from
Apr 10, 2019

Commits on Apr 4, 2019

  1. feat(jsii-spec): Model parameter optionality

    Method `Parameters` now carry an `optional` flag that indicates whether
    they are optional or required, and the `TypeReference#optional` field
    was renamed to `TypeReference#nullable` to better reflect its semantics.
    
    This also brings more flexibility in that it is now possible to model a
    method with a nullable or defaulted argument that is followed by some
    non-optional argument, and still obtain a reasonable type specification,
    where previously this was an error.
    
    Finally, in order to better reflect the type model of TypeScript and
    Javascript, all `any` type references are now denoted `nullable`.
    
    BREAKING CHANGE: JSII assemblies generated by older versions of the tool
    will fail loading with this new version, and vice-versa. Re-compile your
    projects in order to fix this.
    
    Fixes #296
    Fixes #414
    RomainMuller committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    a772323 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Configuration menu
    Copy the full SHA
    ee514aa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65585a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. Configuration menu
    Copy the full SHA
    ca26723 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52f04e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. WIP

    RomainMuller committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    cf59f8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    04c3a94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d9be27f View commit details
    Browse the repository at this point in the history