-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsii-spec): Model parameter optionality #432
Merged
Merged
Commits on Apr 4, 2019
-
feat(jsii-spec): Model parameter optionality
Method `Parameters` now carry an `optional` flag that indicates whether they are optional or required, and the `TypeReference#optional` field was renamed to `TypeReference#nullable` to better reflect its semantics. This also brings more flexibility in that it is now possible to model a method with a nullable or defaulted argument that is followed by some non-optional argument, and still obtain a reasonable type specification, where previously this was an error. Finally, in order to better reflect the type model of TypeScript and Javascript, all `any` type references are now denoted `nullable`. BREAKING CHANGE: JSII assemblies generated by older versions of the tool will fail loading with this new version, and vice-versa. Re-compile your projects in order to fix this. Fixes #296 Fixes #414
Configuration menu - View commit details
-
Copy full SHA for a772323 - Browse repository at this point
Copy the full SHA a772323View commit details
Commits on Apr 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ee514aa - Browse repository at this point
Copy the full SHA ee514aaView commit details -
Merge remote-tracking branch 'origin/master' into rmuller/remodel-par…
…ameter-optionality
Configuration menu - View commit details
-
Copy full SHA for 65585a2 - Browse repository at this point
Copy the full SHA 65585a2View commit details
Commits on Apr 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ca26723 - Browse repository at this point
Copy the full SHA ca26723View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52f04e3 - Browse repository at this point
Copy the full SHA 52f04e3View commit details
Commits on Apr 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for cf59f8c - Browse repository at this point
Copy the full SHA cf59f8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04c3a94 - Browse repository at this point
Copy the full SHA 04c3a94View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9be27f - Browse repository at this point
Copy the full SHA d9be27fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.