Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pacmak): invokeBinScript fails when using symlinked cache #4389

Merged
merged 3 commits into from
Jan 3, 2024
Merged

fix(pacmak): invokeBinScript fails when using symlinked cache #4389

merged 3 commits into from
Jan 3, 2024

Commits on Jan 3, 2024

  1. fix(pacmak): invokeBinScript fails when using symlinked cache 

    This was previously attempted to fix in #4324
While the above fix resolves issues with dependencies, it causes failures when the binary is shelling out to other node processes. This is due to the intrusive and indiscriminate overloading of NODE_OPTIONS, which will forcibly apply to any child processes as well. While in theory adding the symlink flags should not be an issue, this seems to trigger a bug in node: nodejs/node#41000

tl;dr this all sucks very much and we are now just disabling the runtime cache for binaries.
    @mrgrain
    mrgrain committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f16e89d View commit details
    Browse the repository at this point in the history

  2. fixup generated code

    @mrgrain
    mrgrain committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    1e7a595 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @mrgrain
    mrgrain committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    2b35ce2 View commit details
    Browse the repository at this point in the history