fix(python): maintain inheritance chain for structs #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because structs all inherit from TypedDict, and TypedDict erases the inheritance chain of structs, we have to maintain a copy of the inheritance hierarchy on the class objects, for later use during doc generation. This addresses (part of) #473.
RomainMuller
approved these changes
Apr 23, 2019
| code.openBlock(`class _${this.name}(${classParams.concat(["total=False"]).join(", ")})`); | ||
| for (const member of optionalMembers) { | ||
| member.emit(code, resolver); | ||
| } | ||
| code.closeBlock(); | ||
|
|
||
| // Now we'll emit the mandatory members. | ||
| code.line(`@jsii.data_type(jsii_type="${this.fqn}")`); | ||
| code.line(`@jsii.data_type(jsii_type="${this.fqn}", jsii_struct_bases=[_${this.name}])`); |
There was a problem hiding this comment.
What's the _ for here?
There was a problem hiding this comment.
Every struct gets compiled into 2 classes:
class _MyStruct(...):
...
class MyStruct(_MyStruct):
...One holds the required fields, the other one the optional fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because structs all inherit from TypedDict, and TypedDict erases the
inheritance chain of structs, we have to maintain a copy of the
inheritance hierarchy on the class objects, for later use during
doc generation.
This addresses (part of) #473.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.