Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): overhauled structs with native implementation, builders, ... #694

Merged
merged 5 commits into from
Aug 12, 2019

Conversation

bmaizels
Copy link
Contributor

@bmaizels bmaizels commented Aug 9, 2019

Overhauled structs with native implementation, builders, equals and hashCode and creation from JSII.

Fixes #525


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…s, equals and hashcode and creation from JSII. Additionally fixed a bug with diamond inheritance having duplicate properties
@bmaizels bmaizels requested a review from a team as a code owner August 9, 2019 22:05
@RomainMuller RomainMuller changed the title Java bindings: overhauled structs with native implementation, builder… feat(java): overhauled structs with native implementation, builders, ... Aug 9, 2019
RomainMuller
RomainMuller previously approved these changes Aug 12, 2019
@mergify mergify bot dismissed RomainMuller’s stale review August 12, 2019 17:26

Pull request has been modified.

@aws aws deleted a comment from mergify bot Aug 12, 2019
@aws aws deleted a comment from mergify bot Aug 12, 2019
RomainMuller
RomainMuller previously approved these changes Aug 12, 2019
Copy link
Contributor

@spfink spfink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other questions/thoughts:

Would be nice if there was imports and no fqcn
Can we get toBuilder() methods?

@RomainMuller RomainMuller added the pr/do-not-merge This PR should not be merged at this time. label Aug 12, 2019
@RomainMuller
Copy link
Contributor

@bmaizels I've suspended the auto-merging of this PR so you can go through @spfink's suggestions and decide what you do with them... For some, maybe what you want to do is create an issue to look into that later (some of the comments are very much related to cosmetic improvements to generated code, which is good, but probably doesn't need to block this PR).

Feel free to remove the do-not-merge tag if you want to go with the current revision. That should un-block auto-merge.

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2019

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: 'BREAKING CHANGE: <describe what changed + link for details>'
    • Issues: Indicate issues fixed via: 'Fixes #xxx' or 'Closes #xxx'

@aws aws deleted a comment from mergify bot Aug 12, 2019
@aws aws deleted a comment from mergify bot Aug 12, 2019
@bmaizels bmaizels removed the pr/do-not-merge This PR should not be merged at this time. label Aug 12, 2019
@RomainMuller RomainMuller merged commit b0b3fd2 into master Aug 12, 2019
@RomainMuller RomainMuller deleted the bmaizels/jsii-development branch August 12, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java: diamond interface inheritance emits double members
3 participants