Skip to content

Conversation

sergkondr
Copy link
Contributor

Fixes #127

Description
Change env variable PORT -> WEBHOOK_PORT as it is described in the docs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergkondr sergkondr requested a review from a team as a code owner December 12, 2022 13:25
@sergkondr sergkondr requested a review from engedaam December 12, 2022 13:25
@ellistarn
Copy link
Contributor

Nice catch! Looking at our helm chart, it's definitely WebhookPort

@coveralls
Copy link

coveralls commented Dec 12, 2022

Pull Request Test Coverage Report for Build 3676205689

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 75.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/options/options.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/scheduling/requirements.go 2 98.5%
pkg/controllers/node/controller.go 4 59.7%
Totals Coverage Status
Change from base Build 3660279282: -0.05%
Covered Lines: 5550
Relevant Lines: 7308

💛 - Coveralls

@sergkondr
Copy link
Contributor Author

@ellistarn thank you! And thank you for such a lovely thing like Karpenter :)
Do I have to do something with this pull request to ensure it is good enough to be merged?

@ellistarn
Copy link
Contributor

@ellistarn thank you! And thank you for such a lovely thing like Karpenter :)
Do I have to do something with this pull request to ensure it is good enough to be merged?

Nope you're good. Looks like github actions is on holiday -- that last job won't report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration parameter for webhook port
3 participants