Skip to content

chore: Short requeue to check for emptiness rather than using an observer #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2022
Merged

chore: Short requeue to check for emptiness rather than using an observer #139

merged 1 commit into from
Dec 21, 2022

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • We can simplify the eviction observer mechanism by doing a short requeue on the node controller to check for emptiness

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner December 20, 2022 23:45
@coveralls
Copy link

coveralls commented Dec 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3745062312

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.09%) to 77.482%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/state/cluster.go 1 88.76%
pkg/utils/atomic/slice.go 10 0%
Totals Coverage Status
Change from base Build 3743280952: 0.09%
Covered Lines: 5698
Relevant Lines: 7354
💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 913efba into kubernetes-sigs:main Dec 21, 2022
@jonathan-innis jonathan-innis deleted the remove-eviction-observer branch December 21, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@njtran njtran Awaiting requested review from njtran njtran was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @ellistarn