chore: Enable userAgent version specification in operator #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
enable-version-in-useragent
branch
from
c1418a8 to
206af5e
Compare
Pull Request Test Coverage Report for Build 6570988105
💛 - Coveralls |
njtran
approved these changes
Oct 19, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This PR enables version to be specified and injected during the binary build to log the version and add the version to the userAgent that is stored in the metadata information when Karpenter makes calls to the apiserver.
You can inject the version when you build the binary by running the following:
go build cmd/controller/main.go GOFLAGS="-ldflags=-X=github.com/aws/karpenter-core/pkg/operator.Version=$(shell git describe --tags --always)"How was this change tested?
make applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.