Skip to content

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Nov 28, 2022

Fixes #

Description

  • Fixes missed changes in scheduling profiling file
  • Adds the build-tag to the linter to catch misses in this file in the future

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner November 28, 2022 05:19
@jonathan-innis jonathan-innis force-pushed the fix-scheduling-profiling branch from 62d53e8 to c2d3c1c Compare November 28, 2022 05:21
@jonathan-innis jonathan-innis enabled auto-merge (squash) November 28, 2022 05:21
@coveralls
Copy link

coveralls commented Nov 28, 2022

Pull Request Test Coverage Report for Build 3562810893

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 75.676%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/controller.go 4 59.7%
Totals Coverage Status
Change from base Build 3550845634: -0.06%
Covered Lines: 5317
Relevant Lines: 7026

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the fix-scheduling-profiling branch from c2d3c1c to 94700c7 Compare November 28, 2022 07:59
@jonathan-innis jonathan-innis force-pushed the fix-scheduling-profiling branch from 94700c7 to 721fe38 Compare November 28, 2022 08:00
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathan-innis jonathan-innis merged commit e832b62 into kubernetes-sigs:main Nov 29, 2022
@jonathan-innis jonathan-innis deleted the fix-scheduling-profiling branch December 2, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants