Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Machine Migration #3408

Merged
merged 14 commits into from
Apr 21, 2023
Merged

feat: Machine Migration #3408

merged 14 commits into from
Apr 21, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Feb 15, 2023 •
edited
Loading

Fixes #2734
Fixes #2832
Fixes #2831
Fixes #2385
Fixes #1681
Fixes #3525
Fixes #3436
Fixes #3755

Description

  • Updates the interruption controller to delete machines and to fire machines_terminated metrics

karpenter-core buddy PR for this change: kubernetes-sigs/karpenter#176

How was this change tested?

  • Manual Testing of:
    • Large Scale Ups (1000 nodes)
    • Machine Linking
    • Garbage Collection
  • make e2etests
  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 15, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 6d2f08d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6442e82518ebd90009c19f5d

@jonathan-innis jonathan-innis force-pushed the machine-migration branch 10 times, most recently from 058f16f to 1703e33 Compare February 22, 2023 00:12
@jonathan-innis jonathan-innis force-pushed the machine-migration branch 4 times, most recently from 58c6c4f to 2a585ae Compare February 24, 2023 18:54
@jonathan-innis jonathan-innis force-pushed the machine-migration branch 3 times, most recently from 1c6c9a6 to 55588c0 Compare March 7, 2023 22:53
@jonathan-innis jonathan-innis marked this pull request as ready for review March 7, 2023 23:03
@jonathan-innis jonathan-innis requested a review from a team as a code owner March 7, 2023 23:03
@jonathan-innis jonathan-innis force-pushed the machine-migration branch 4 times, most recently from 98799b3 to 9837713 Compare March 8, 2023 00:50
@jonathan-innis jonathan-innis changed the title feat: Machine migration feat: Machine Migration Mar 8, 2023
jonathan-innis
jonathan-innis commented Mar 8, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-d4c06f97ae3d5c4ecddd993974defd5d9ae707fa. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

njtran
njtran previously approved these changes Apr 20, 2023
View reviewed changes
jonathan-innis
jonathan-innis commented Apr 20, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-a1428a965f15099422a7da4f8448a8437a92f198. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis force-pushed the machine-migration branch 2 times, most recently from 6fb9e62 to 7433edf Compare April 21, 2023 17:49
jonathan-innis
jonathan-innis commented Apr 21, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

jonathan-innis
jonathan-innis commented Apr 21, 2023
View reviewed changes
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-bf0d48b298e78423b88ab0e2a3d8ef5748e502d3. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis force-pushed the machine-migration branch 2 times, most recently from c896b18 to c47706d Compare April 21, 2023 19:46
bwagner5
bwagner5 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis enabled auto-merge (squash) April 21, 2023 19:56
@jonathan-innis jonathan-innis enabled auto-merge (squash) April 21, 2023 19:56
@jonathan-innis jonathan-innis merged commit 7afa563 into aws:main Apr 21, 2023
@jonathan-innis jonathan-innis deleted the machine-migration branch April 21, 2023 20:09
@maximethebault maximethebault mentioned this pull request Apr 29, 2023
Open
@jonathan-innis jonathan-innis mentioned this pull request May 3, 2023
Merged
3 tasks
This was referenced May 17, 2023
Closed
Closed
@anthonyhaussman anthonyhaussman mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn left review comments

@bwagner5 bwagner5 bwagner5 approved these changes

@njtran njtran njtran left review comments

Assignees
No one assigned
Labels
dependency/karpenter-core PRs that take strict dependency on a change in karpenter-core
Projects
None yet
Milestone
No milestone
4 participants
@jonathan-innis @ellistarn @bwagner5 @njtran