Update patchYamlJsonPackage.js to handle paths with spaces in applyPatch
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated PR for #268. |
kmile
approved these changes
May 29, 2024
Why? That loses the PR comments. Please just force-push to your existing branch instead of creating new PRs. |
justinmk3
reviewed
May 29, 2024
justinmk3
approved these changes
May 29, 2024
…yPatch` When `language-servers` is checked out under a directory that contains spaces in the full path, `npm install` will fail to complete due to `patchYamlJsonPackage.js`. This commit fixes this issue by ensuring file paths are quoted to support spaces in them.
|
I've updated to use |
Truth be told, I haven't used the PR feature for GitHub in ages, and I did not realize you could force-push to update an existing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
language-serversis checked out under a directory that contains spaces in the full path,npm installwill fail to complete due topatchYamlJsonPackage.js.Solution
This commit fixes this issue by ensuring file paths are quoted to support spaces in them.
Testing
Ensured
npm installsucceeds in a directory with spaces in the full path (i.e. under a user'sApplication Supportfolder for Sublime Text on OS X).License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.