Bug Fix: OTA_Resume only restarts selftest timer while selftesting #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dachalco
changed the title
ActoryOu
approved these changes
Jun 17, 2022
n9wxu
approved these changes
Jun 17, 2022
dachalco
force-pushed
the
fix-resume-no-selftest
branch
from
4f542dc
to
7d743cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug detailed in issue #421 and add test coverage for the changes.
Test Bed
For integration tests, I modified the OTA MQTT demo provided by the csdk. Test application initializes/starts OTA agent, then calls
OTA_Resumewhile no OTAs are pending or in flight.Integration Test Logs (Before)
Integration Test Logs (After)
Note my added logs containing "Int-Test". Before the fix, you'll notice the log indicating when
OTA_Resumewas called and the repeated cycles of self-test timer fire then reboot. With the fix, these app logs were retained, but not reported per the fix.Checklist:
I have read and applied the rules stated in CONTRIBUTING.md.There isn't one.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.