-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax extension_update_paths argument to text #277
Conversation
All of the other extension functions use text as name, so this appears to be an arbitrary restriction. Hence, relaxing the argument from name to text.
Apply pg_indent Co-authored-by: Adam Guo <adamguo@amazon.com>
To update the extension version you'll need to bump EXTVERSION in the Makefile as well. Not sure if that's causing these regression test failures though |
All of the other extension functions use text as name, so this appears to be an arbitrary restriction. Hence, relaxing the argument from name to text.
Thanks @adamguo0, fixed it! 😄 |
Sorry I haven't gotten to this in a while -- the change looks good to me. I did a manual sanity check to make sure that after updating pg_tle from 1.4.0 to 1.4.1, the function works as expected |
Hi, do you mind elaborating what are the restrictions that you're facing before this change? |
Hi @anth0nyleung 😃, Note that This PR addresses a long time pending issue, #126 raised by @jkatz. 😄 |
As a side-note there's another issue preventing users from creating extensions with almost-63 chars. Since function names are capped at 63 chars, I don't think our current implementation can handle this case. We'll need to address that separately |
Issue #, if available: #126
Description of changes:
All of the other extension functions use text as name, so this appears to be an arbitrary restriction. Hence, relaxing the argument from name to text.
The
name
data (currently inextension_update_paths()
) can hold 63 characters only (ref #define NAMEDATALEN 64). Whereastext
data type (updated in this PR) has no limit at all.Note that
install_extension()
already usestext
instead ofname
data type for the extension-name's argument. So a user can create an extension with names that are >63 characters, but the operation will fail when trying to find its update paths usingextension_update_paths()
function because it's using a data type that limits the extension name to 63 chars!By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.