Only send increased retire_prior_to value on the last NEW_CONNECTION_ID frame #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't be needed after private-octopus/picoquic#1150 is merged |
|
Picoquic merged in their fix (private-octopus/picoquic#1150) and interop is looking much better: We don't need this workaround now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #522
Some client implementation are unable to process NEW_CONNECTION_ID frames that retire all existing connection IDs. This means that when the handshake completes and we request to replace the handshake connection ID, the client fails. To improve interoperability with these clients we can apply the retire_prior_to value only after we've given the client a new connection ID to replace the handshake connection ID. Since the minimum active_connection_id_limit is 2, the client should always have room for one more ID without having to retire the handshake connection ID.
Before & After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.