fix(test): narrow valgrind suppressions #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
force-pushed
the
fix-valgrind-errors
branch
11 times, most recently
from
691b0fb
to
89de95d
Compare
jmayclin
force-pushed
the
fix-valgrind-errors
branch
4 times, most recently
from
048b109
to
12329bb
Compare
jmayclin
force-pushed
the
fix-valgrind-errors
branch
from
584afea
to
be223c4
Compare
lrstewart
reviewed
Jan 19, 2024
toidiu
reviewed
Jan 26, 2024
|
Attaching the Tracking issue #3758 |
- fix self-talk-alpn-test.c - remove suppressions
goatgoose
reviewed
Jan 30, 2024
- correct client protocol length - add not null assertions - use predefined bytearray equal macro
goatgoose
approved these changes
Jan 31, 2024
dougch
approved these changes
Feb 2, 2024
- clang-format does a minor self destruct if you don't include trailing commas, so include trailing commas.
- remove the fun from the comment
lrstewart
reviewed
Mar 6, 2024
- remove gen suppressions on the pedantic valgrind path
lrstewart
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4363
Resolves #1600
Description of changes:
Suppression Update: Prefer Narrow
fun:mainwildcard leak.remove aws-lc from pedantic valgrind
Fix some memory errors
s2n_examples_test.cfound in refactor: ossl x509 parsing #4351s2n_key_update_threads_test.cs2n_self_talk_alpn_test.c. This test had many copy pasted cases and was difficult to read, so I refactored it into individual test cases.Valgrind Command Restructuring
123: previous error code9was boring and I assumed it was os-caused--error-limit=noto show all errors in CITesting:
All current CI should pass on this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.