fix: allow for clock skew in resumption #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Jul 16, 2024
- sanity check the amount of clock skew
- typo, spelling is hard :'(
maddeleine
approved these changes
Jul 16, 2024
- add hard cap for clock skew at 1 hour
- okay, I actually went through a lot of work to undo this assuming that my local clang format was just being weird, but this is what it insists on
jmayclin
commented
Jul 19, 2024
lrstewart
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
s2n-tls is currently unable to resume session tickets if they were issued in the "future" from the perspective of the resuming host. This means that if there is any relatively significant clock skew between the resuming host and the issuing host, the resumption attempt will fail.
This PR changes that behavior to allow session tickets to be resumed if they were issued in the "future". We are making the assumption that the clock skew is less than one week, which seems reasonable.
Testing:
modified test to assert on new behavior
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.