-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: only build requested unit tests in nix #4770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; easier to iterate
I shouldn't have just automatically stuck every command in a subshell 😅
I also checked the other functions for similar problems: no other exports, and no other private / helper functions. Out of paranoia, I also double-checked that exports are available in commands as expected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renegotiate_apache passes, LGTM
Description of changes:
Fixes a couple usability issues with the nix develop script that were bugging me:
Testing:
I ran variations of the command locally. It seems to be able to handle wildcards / exact names / nothing just fine. The CI has a test of the nothing / all tests case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.