Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings): pin unicode-width #4785

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore(bindings): pin unicode-width #4785

merged 1 commit into from
Sep 20, 2024

Conversation

lrstewart
Copy link
Contributor

@lrstewart lrstewart commented Sep 19, 2024

Description of changes:

Fix broken CI by pinning unicode-width:

error[E0658]: use of unstable library feature 'mixed_integer_ops'
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/unicode-width-0.1.14/src/tables.rs:407:22
    |
407 |                 (sum.wrapping_add_signed(isize::from(add)), info)
    |                      ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #87840 <https://github.com/rust-lang/rust/issues/87840> for more information

error[E0658]: use of unstable library feature 'mixed_integer_ops'
   --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/unicode-width-0.1.14/src/tables.rs:702:22
    |
702 |                 (sum.wrapping_add_signed(isize::from(add)), info)
    |                      ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #87840 <https://github.com/rust-lang/rust/issues/87840> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `unicode-width` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

wrapping_add_signed became stable in 1.66.0: https://doc.rust-lang.org/core/primitive.isize.html#method.wrapping_add_unsigned

Testing:

CI passes again

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Sep 19, 2024
@lrstewart lrstewart marked this pull request as ready for review September 19, 2024 23:01
@lrstewart lrstewart changed the title fix(bindings): pin unicode-width chore(bindings): pin unicode-width Sep 19, 2024
@lrstewart lrstewart enabled auto-merge (squash) September 19, 2024 23:26
@lrstewart lrstewart merged commit 003412f into aws:main Sep 20, 2024
37 checks passed
@lrstewart lrstewart deleted the fix branch September 20, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants