fix: don't iterate over certs if not validating certs #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix a performance regression for customers with a very large number of certificates.
Testing:
Added a unit test.
Adding a benchmark test for this would currently be difficult, because our benchmark tests use Rust. The Rust bindings currently don't support multiple certificates of the same type (see the description of #3860), so can only load 3 cert chains. However, a customer who uses 10k certificates has tested this fix and verified that it fixes the performance regression. I also verified it locally with perf.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.