Skip to content

Commit 61fc611

Browse files
committed
update image uris and tests
1 parent aee40bc commit 61fc611

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

src/sagemaker/image_uris.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -471,14 +471,14 @@ def _get_end_of_support_warn_message(end_of_support, framework, version):
471471
time_delt_days = (end_of_support_dt - current_dt).days
472472
if current_dt >= end_of_support_dt:
473473
return (
474-
f"Unsupported DLC {framework} version: {version}."
475-
f"Please choose a supported version from our support policy - {dlc_support_policy}"
474+
f"The {framework} {version} DLC has reached end of support. "
475+
f"Please choose a supported version from our support policy - {dlc_support_policy}."
476476
)
477477
if time_delt_days <= 60:
478478
return (
479479
f"The {framework} {version} DLC is approaching end of support, "
480-
f"and patching will stop on {end_of_support}. "
481-
f"Please choose a supported version from our support policy - {dlc_support_policy}"
480+
f"and patching will stop on {end_of_support_dt.strftime('%Y-%m-%d %Z')}. "
481+
f"Please choose a supported version from our support policy - {dlc_support_policy}."
482482
)
483483
return ""
484484

@@ -488,6 +488,8 @@ def _validate_version_and_set_if_needed(version, config, framework):
488488
available_versions = list(config["versions"].keys())
489489
aliased_versions = list(config.get("version_aliases", {}).keys())
490490

491+
492+
491493
if len(available_versions) == 1 and version not in aliased_versions:
492494
log_message = "Defaulting to the only supported framework/algorithm version: {}.".format(
493495
available_versions[0]
@@ -502,10 +504,14 @@ def _validate_version_and_set_if_needed(version, config, framework):
502504
_validate_arg(version, available_versions + aliased_versions, "{} version".format(framework))
503505

504506
# For DLCs, warn if image is out of support
505-
end_of_support = config.get("end_of_support")
507+
long_version = version
508+
if version in aliased_versions:
509+
long_version = config["version_aliases"][version]
510+
end_of_support = config["versions"][long_version].get("end_of_support")
506511
end_of_support_warning = _get_end_of_support_warn_message(end_of_support, framework, version)
507512
if end_of_support_warning:
508513
logger.warning(end_of_support_warning)
514+
509515
return version
510516

511517

tests/unit/sagemaker/image_uris/test_dlc_frameworks.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,6 @@ def test_end_of_support():
528528
warn_message = image_uris._get_end_of_support_warn_message(end_of_support=end_of_support, framework="pytorch", version="1.6.0")
529529

530530
assert warn_message == (
531-
f"Unsupported DLC pytorch version: 1.6.0"
532-
f"Please choose a supported version from our support policy - {dlc_support_policy}"
531+
f"The pytorch 1.6.0 DLC has reached end of support. "
532+
f"Please choose a supported version from our support policy - {dlc_support_policy}."
533533
)

0 commit comments

Comments
 (0)