Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es:ESHttpPut in ElasticsearchHttpPostPolicy #1011

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

Gaurav2Github
Copy link
Contributor

@Gaurav2Github Gaurav2Github commented Jul 3, 2019

Include es:ESHttpPut action in ElasticsearchHttpPostPolicy Template

*Issue #1010

Description of changes:
Add es:ESHttpPut action available in Policy Template List as part of ElasticsearchHttpPostPolicy template.

Description of how you validated changes:

Checklist:

  • Write/update tests(policy templates)
  • make pr passes
  • Update documentation(no change required)
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31(no change required)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Include es:ESHttpPut action in ElasticsearchHttpPostPolicy Template
@jlhood
Copy link
Contributor

jlhood commented Jul 3, 2019

@Gaurav2Github Thanks so much for this contribution! However, the Travis build is failing. You indicated that no unit test change is necessary, but we do have unit tests for policy templates. You need to update the 3 all_policy_templates.json files in the tests directory to match your change. Here's one of those files.

@Gaurav2Github
Copy link
Contributor Author

Thanks for highlighting. Test policy templates updated.

@keetonian keetonian merged commit cd05bab into aws:develop Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants