Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to_cloudformation functions of PushEventSource class docstrings #1018

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

53ningen
Copy link
Contributor

@53ningen 53ningen commented Jul 7, 2019

Issue #, if available:
#1017

I'm sorry if I was wrong but I understand CloudWatch Events trigger is no pull event.
So I think docstrings of to_cloudformation of CloudWatchEvent class and Schedule class have to fix.

  • [-] Write/update tests
  • [-] make pr passes
  • Update documentation
  • [-] Verify transformed template deploys and application functions as expected
  • [-] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@275e461). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1018   +/-   ##
==========================================
  Coverage           ?   94.81%           
==========================================
  Files              ?       69           
  Lines              ?     3240           
  Branches           ?      631           
==========================================
  Hits               ?     3072           
  Misses             ?       87           
  Partials           ?       81
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 88.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275e461...10d570e. Read the comment docs.

@53ningen
Copy link
Contributor Author

rebased on current develop

@brettstack brettstack merged commit 1e39662 into aws:develop Jul 15, 2019
@53ningen 53ningen deleted the fix/push branch July 16, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants