-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for self managed kafka as an event source #2091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extensive test additions!
I think we also want to add:
- unit tests with intrinsic functions
- 1 integration test without intrinsic functions
- 1 integration test with intrinsic functions
We are working on adding tests to other events/resources I think this is needed.
See:
tests/model/eventsources/test_self_managed_kafka_event_source.py
Outdated
Show resolved
Hide resolved
tests/model/eventsources/test_self_managed_kafka_event_source.py
Outdated
Show resolved
Hide resolved
Thanks for the intrinsic tests! |
The AppVeyor run failed because you added the IP address to the input test templates and not the output ones |
Codecov Report
@@ Coverage Diff @@
## develop #2091 +/- ##
===========================================
+ Coverage 93.58% 94.33% +0.75%
===========================================
Files 90 95 +5
Lines 6124 6495 +371
Branches 1260 1306 +46
===========================================
+ Hits 5731 6127 +396
+ Misses 183 170 -13
+ Partials 210 198 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Two small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6ab283c
to
c1cca92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, just a small non blocking change.
Issue #, if available:
Description of changes:
To provide supporting SelfManagedKafka as an event source type in SAM and also provide support for SASL/PLAIN (BASIC_AUTH) as an Auth mechanism.
Description of how you validated changes:
Wrote a couple of tests
Checklist:
make pr
passes