fix: remove py3.6 support and add py3.9 and py3.10 #2311
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2311 +/- ##
===========================================
+ Coverage 93.58% 94.47% +0.89%
===========================================
Files 90 97 +7
Lines 6124 7062 +938
Branches 1260 1434 +174
===========================================
+ Hits 5731 6672 +941
+ Misses 183 177 -6
- Partials 210 213 +3
Continue to review full report at Codecov.
|
| @@ -66,6 +66,7 @@ def read_requirements(req="base.txt"): | |||
| "NOTICE", | |||
| "THIRD_PARTY_LICENSES", | |||
| ), | |||
| python_requires=">=3.7, <=4.0, !=4.0", | |||
There was a problem hiding this comment.
Should we restrict this to only supported versions instead of auto enabling new python versions under 4.0?
There was a problem hiding this comment.
Rethinking this. Since this repo is a library, leaving it open like this is likely fine. We may run into problems if we use newer lang features but we have to support the min version anyways.
There was a problem hiding this comment.
Why <=4.0 and !=4.0 instead of just <4.0?
(Or better yet only >=3.7 https://iscinumpy.dev/post/bound-version-constraints/)
I can make a follow up PR to address those. |
Issue #, if available:
#2291
Description of changes:
Python3.6 have reached its EOL, this PR removes support for using serverless-application-model as a library in a python3.6 environment.
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.